[PW-5743] Disable all payment methods by default #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payment methods must be enabled selectively by merchants after setting up other required settings, like API key.
michaelpaul
requested review from
AlexandrosMor,
acampos1916,
rikterbeek,
peterojo,
Morerice and
tnaber
as code owners
Morerice
previously approved these changes
Feb 17, 2022
peterojo
previously approved these changes
Feb 18, 2022
acampos1916
previously approved these changes
Feb 23, 2022
peterojo
previously approved these changes
Feb 23, 2022
michaelpaul
dismissed stale reviews from peterojo and acampos1916
via
5a7b2d2
acampos1916
previously approved these changes
Feb 23, 2022
acampos1916
previously approved these changes
Feb 24, 2022
Morerice
previously approved these changes
Feb 24, 2022
michaelpaul
changed the title
michaelpaul
dismissed stale reviews from Morerice and acampos1916
via
c7e901f
|
Kudos, SonarCloud Quality Gate passed!
|
acampos1916
approved these changes
Feb 25, 2022
peterojo
approved these changes
Feb 25, 2022
AlexandrosMor
approved these changes
Feb 25, 2022
aziya-im
added this to In Progress
in Magento Product Roadmap - Please Note: This is not set-in-stone. Unexpected higher priorities can always interfere with the planning.
via automation
aziya-im
moved this from In Progress
to Done
in Magento Product Roadmap - Please Note: This is not set-in-stone. Unexpected higher priorities can always interfere with the planning.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right after installing the plugin, the payment methods "Credit Card" and "OneClick" come enabled. They won't work without setting up all the required settings (e.g. API key).
Normally, this is not an issue for regular merchants. But it breaks Magento core MFTF tests, which then blocks us from publishing on their Marketplace.
This PR disables all methods by default and introduces a Github Actions workflow to check if the core compatibility is maintained.
Tested scenarios