[PW-6287] - Check if LPM supports recurring before adding recurring info

[Morerice]

Description
Currently we are attempting to tokenize any alternative payment methods based on the settings related to stored card payments. The functionality should be divided and a list of payment methods that support recurring should be created. However from this list, only SEPA should be enabled for now.

Also add a new Token Type option to identify if the created token for alternative payment methods is a CardOnFile or a Subscription token.

Note that when upgrading the current Store alternative payment methods option will be set to No. This is done to ensure that once enabled, the admin will also choose what type of token should be created.

Tested scenarios

• Card payment
• Card payment (CardOnFile token created)
• Card payment (Subscription token created)
• Tokenized card payment (CardOnFile)
• SEPA payment
• SEPA payment (CardOnFile token created)
• SEPA payment (Subscription token created)

[acampos1916]

Left a few comments.

[peterojo]

maybe you forgot to write some docs for this method? or why the extra lines?

[Morerice]

Good catch 💪 Updated in c4ba1d3

[peterojo]

Cool! 😎

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

No Coverage information
0.0% Duplication

[evgv]

Hi

Currently I'm working on GraphQL implementation Adyen plugin with our frontend, so I pulled develop and everything was working well, but after these update and adding these code

if ($additionalData[self::BRAND_CODE] === Data::SEPA) { $additionalDataToSave = $this->getSepaAdditionalDataToSave($stateData); }

into the AdyenHppDataAssignObserver it stopped working because after second time when this event is triggering the additional data received from payment object (table) there is no brand_code field because in the payment table no such field, this data stored in additional_information field so as the temporary solution we can add these code

if (isset($additionalData['additional_information'])) { $additionalData = array_merge($additionalData, $additionalData['additional_information']); }

right above the previous the

$additionalData = DataArrayValidator::getArrayOnlyWithApprovedKeys( $additionalData, self::$approvedAdditionalDataKeys );

to add brand_code from additional_information

this error can be reproduced within HPP method as PP for example

UPD

or we could check the cc_type field instead of brand_code because in case of HPP it stored brand code value, for example for PP cc_type = paypal