[PW-6021] Add 'maintain state' option on payment confirmation

[tnaber]

Description
In #1276 it was suggested to implement a 'No status change' option on payment confirmation to allow for different flows (e.g. capturing after POD, see discussion). This was already possible in 7.2.0 by not setting any status (leaving it to '-- Please Select --'), however this feature disappeared for later versions. This PR adds the option to select 'Maintain status' in the Order status: payment confirmed dropdown. The '-- Please Select --' option has been removed to prevent confusion to which status will be selected, the default is 'Processing'.

The state will be maintained only in the Manual Capture flow.

Tested scenarios

• Manual capture
• Immediate capture
• Verified by community

Fixed issue:
Closes #1276

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[sheppeybrian]

@tnaber
Just upgraded to 8.2.0 this solution corrects the status/state issue but creates a pending invoice not a paid one.

Processing flow:
Order placed and payment authorized. (Manual Capture)

Invoice created at a later date via magento backend as online payment.

Capture notification received however the invoice is generated with invoice status "Pending" and not "Paid".

This makes the invoice worthless and if further status changes are attempted, like shipping it will cancel the order down completely.

Back to 7.2.0 which works no issues.

[tnaber]

Hi @sheppeybrian,

Sad to hear that you had to go back to 7.2.0 again. I don't completely understand what you mean so I'll write down the steps I'm taking, can you point out where your flow differs from mine?

My setup:

1. Place order, order in Payment Review
2. Authorization notification received, order in Pending
3. Invoice created, order in Pending
4. Capture notification received, order in Pending
5. Ship order, order Complete

When testing the flow where we ship before creating the invoice I notice some strange behaviour

1. Place order, order in Payment Review
2. Authorization notification received, order in Pending
3. Order shipped, order in Processing
4. Invoice created, order Closed
5. Capture notification received but not processed, order in Closed

Am I correct in assuming that you are using the second flow?
If so, do you mean that an invoice should be directly opened as a 'Paid' invoice? As far as I understand it, the capture notification has not been received at that point

If this is not the flow you mean, would you able to provide your flow in a similar format?

Cheers,
Titus

[sheppeybrian]

Hello Titus So our flow is the same as your second example except that 3 & 4 are reversed. I don't see this making much of a difference. However it's the Invoice created stage that's the issue. (4) It looked fine during testing as the invoice is created, but on closer inspection the invoice status is marked "Status:Pending" and not "Paid" Due to this, Magento will try to prevent you from handling the order any further and close it So I would deem that magento is correctly issuing an invoice as "pending" awaiting a response for Adyen "capture" to update it to "Paid", which does not occur. I'm not a developer but this is what I see as being the issue that occurred. Many Thanks Brian AstroTex Ltd t/a expressgrass.com Tribune Drive, Trinity Trading Estate SITTINGBOURNE Kent ME10 2PG Map <https://www.google.com/maps/dir//expressgrass> *tel*: 0844 855 4704 *direct line*: 01795 385202 *fax*: 01795 385001 *email*: ***@***.*** ***@***.***>**web*: www.expressgrass.com *Reviews: Google Reviews <https://g.page/expressgrass/review?kd>* P please don't print this e-mail unless you really need to This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of expressgrass.com. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error

…

On Tue, 12 Apr 2022 at 08:59, Titus Naber ***@***.***> wrote: Hi @sheppeybrian <https://github.com/sheppeybrian>, Sad to hear that you had to go back to 7.2.0 again. I don't completely understand what you mean so I'll write down the steps I'm taking, can you point out where your flow differs from mine? My setup: [image: image] <https://user-images.githubusercontent.com/23633368/162906552-f14cbe33-f5e7-44ac-a6d0-14c270058839.png> 1. Place order, order in Payment Review 2. Authorization notification received, order in Pending 3. Invoice created, order in Pending 4. Capture notification received, order in Pending 5. Ship order, order Complete When testing the flow where we ship before creating the invoice I notice some strange behaviour 1. Place order, order in Payment Review 2. Authorization notification received, order in Pending 3. Order shipped, order in Processing 4. Invoice created, order Closed 5. Capture notification received but not processed, order in Closed Am I correct in assuming that you are using the second flow? If so, do you mean that an invoice should be directly opened as a 'Paid' invoice? As far as I understand it, the capture notification has not been received at that point If this is not the flow you mean, would you able to provide your flow in a similar format? Cheers, Titus — Reply to this email directly, view it on GitHub <#1390 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKBK7UYKARJDJORY5VVHEDVEUUODANCNFSM5QVNX2DA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tnaber]

Hi Brian,
I did not expect this behaviour to occur and will be diving back into this :)

[sheppeybrian]

No worries, thanks for your help, we did not notice the issue until we put it on the live site and started to process orders. Brian Sent from my pocket, currently out of the office.

…

On Tue, 12 Apr 2022, 14:35 Titus Naber, ***@***.***> wrote: Hi Brian, I did not expect this behaviour to occur and will be diving back into this :) — Reply to this email directly, view it on GitHub <#1390 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKBK7RBYI6LUWWCQGTKMMLVEV3YTANCNFSM5QVNX2DA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jordanvector]

@tnaber was there ever a follow up ticket created to track the fix for the invoice status issue referenced above?

[tnaber]

Hi @jordanvector,
A follow up ticket has been created and the investigation is in progress.
The issue is not necessarily caused by this PR, the problem exists since orders are pushed to the Processing state after an invoice in order to allow for multiple invoices. If an order is shipped before being captured, it will move to Closed. We are currently figuring out the correct flow.

Cheers,
Titus

[jordanvector]

@tnaber understood thank you for the update.

[tnaber]

Hi @jordanvector and @sheppeybrian,

In #1533 you can view our proposed solution. Let me know what you think!
Also let me know whether you think the 'Maintain state' option has become redundant due to this (as the shipping before capture flow can be used without it)

Cheers,
Titus