[PW-6238] Set authorized amount in sales_order_payment #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpaul
requested review from
AlexandrosMor,
acampos1916,
rikterbeek,
peterojo,
Morerice and
tnaber
as code owners
The main workflow was running twice (push + pull_request).
michaelpaul
commented
Mar 15, 2022
| @@ -1,6 +1,6 @@ | |||
| name: Main CI workflow | |||
|
|
|||
| on: [push, pull_request] | |||
| on: [pull_request] | |||
There was a problem hiding this comment.
Running this workflow on push + pull_request causes duplicated runs when members of the repo push to a pull_request.
AlexandrosMor
previously approved these changes
Mar 17, 2022
Morerice
reviewed
Mar 17, 2022
tnaber
previously approved these changes
Mar 21, 2022
Morerice
approved these changes
Mar 23, 2022
acampos1916
approved these changes
Mar 24, 2022
AlexandrosMor
approved these changes
Mar 25, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
amount_authorizedfield insales_order_paymenttable was not getting populated for Adyen HPP, but the credit cards are already initialized in MagentoPayment.phpso the table is updating properly.With this PR when receiving a
AUTHORISATIONnotification and the amount is full authorised, then the amount is updated in thesales_order_paymenttable.Tested scenarios
Tested for CC and IDeal.