Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-5668-2] Orders staying in Payment Review after OFFER_CLOSED #1411

Merged
merged 4 commits into from Mar 28, 2022

Conversation

tnaber
Copy link
Contributor

@tnaber tnaber commented Mar 23, 2022

Description
Some history on this: in PR #1215 a fix was implemented for #1193. As the 'VI' and 'visa' string indicate the same PM but will not pass the string comparison, the notification was skipped thinking that different methods were used. In #1215 a work around was added for the CC flow. However, this did not include CC flow when oneclick was used, this PR adds oneclick to the workaround.

Tested scenarios

  • Oneclick

Fixed issue:
Fixes #1408

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tnaber tnaber merged commit 46c89b7 into develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Again: Orders staying in Payment Review after OFFER_CLOSED
4 participants