[PW-6453] - Ensure all exceptions thrown by resolvers are GraphQl exceptions #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to getAdyenPaymentStatus
…if the cart is related to the customer AFTER the cart becomes inactive
…adyen payment status call
…cart_id, which is then picked up by the adyenPaymentStatus
…. Use them in the graphQl payment details resolver
…lize and also catch any last exception
…yenHppDataAssignObserver
Morerice
requested review from
rikterbeek,
peterojo,
tnaber and
michaelpaul
as code owners
acampos1916
approved these changes
Mar 25, 2022
AlexandrosMor
approved these changes
Mar 25, 2022
peterojo
approved these changes
Mar 28, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in some cases, (if there is an error with the payload in the details call in graphql) a normal exception is thrown. Ultimately this is caught and 'changed' to a graphQl exception, but the message sent back will be
Internal Server Error, which is not informative.A new Exception should be created, specific to graphQl. Ideally we would also check, based on the exception code if the message can be displayed to the user. The latter functionality would also be usable in non-graphql requests in the future.
Tested scenarios
GetAdyenPaymentStatus:
GetAdyenPaymentDetails:
GetAdyenPaymentMethods: