Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-6292] - Show validation error message to shopper #1414

Merged
merged 4 commits into from Apr 6, 2022
Merged

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Mar 24, 2022

Description

Safe errorCode list created and validation errors are shown to shopper according to allowed list.

Tested scenarios

Fixed issue:

@AlexandrosMor
Copy link
Contributor

In the ticket is mentioned that it fixes the issue #1341 so should we add that in the description ?

AlexandrosMor
AlexandrosMor previously approved these changes Mar 25, 2022
tnaber
tnaber previously approved these changes Mar 28, 2022
Copy link
Contributor

@tnaber tnaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the description as to indicate that #1341 is not fully fixed with this PR (now it is closed upon merge)

AlexandrosMor
AlexandrosMor previously approved these changes Mar 30, 2022
Co-authored-by: Michael Paul <michael.paul@adyen.com>
@candemiralp candemiralp dismissed stale reviews from AlexandrosMor and tnaber via 0da50eb April 6, 2022 08:26
tnaber
tnaber previously approved these changes Apr 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@candemiralp candemiralp merged commit 1b0aa91 into develop Apr 6, 2022
@Morerice Morerice mentioned this pull request Apr 6, 2022
@candemiralp candemiralp deleted the PW-6292 branch April 7, 2022 14:44
peterojo pushed a commit that referenced this pull request Apr 11, 2022
* [PW-6292] - Safe errorCode list created and validation errors are shown to shopper according to allowed list.

* [PW-6292] - Allowed list updated.

* [PW-6292] - Strict comparison for checking

Co-authored-by: Michael Paul <michael.paul@adyen.com>

Co-authored-by: cand <can.demiralp@adyen.com>
Co-authored-by: Michael Paul <michael.paul@adyen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants