[PW-6286] Pad shopperReference when getting contracts #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add padding to shopperReference in listRecurringContractByType
AlexandrosMor
requested review from
acampos1916,
rikterbeek,
peterojo,
Morerice,
tnaber,
michaelpaul and
candemiralp
as code owners
acampos1916
approved these changes
Mar 31, 2022
peterojo
approved these changes
Mar 31, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
peterojo
pushed a commit
that referenced
this pull request
Apr 11, 2022
Add padding to shopperReference in listRecurringContractByType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add padding to shopperReference in listRecurringContractByType
Description
The plugin sends a request to Adyen to get all the billing agreements of a shopper, whenever a RECURRING_CONTRACT webhook is handled and vault is not being used.
In case the shopperReference is one digit then in the request should be padded.
For example instead of
shopperReference = 2should beshopperReference=002In other case the request will result in the fetching of incorrect contracts (since the shopperReference is different).
Tested scenarios
RECURRING_CONTRACT