[PW-7252] Fix comparison when handling capture webhook from CA #1742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in Invoice::handleCaptureWebhook we have the following check:
This check will always return false (and hence webhook will always be treated as partial) since $order->getBaseGrandTotal() will return a string, instead of an int. The solution is to call
floatval()
on$order->getBaseGrandTotal()
.Tested scenarios