Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-7252] Fix comparison when handling capture webhook from CA #1742

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

RokPopov
Copy link
Contributor

@RokPopov RokPopov commented Sep 30, 2022

Description
Currently in Invoice::handleCaptureWebhook we have the following check:

$isFullAmountCaptured = $this->adyenDataHelper->originalAmount(
      $notification->getAmountValue(),
      $notification->getAmountCurrency()
) === $order->getBaseGrandTotal();

This check will always return false (and hence webhook will always be treated as partial) since $order->getBaseGrandTotal() will return a string, instead of an int. The solution is to call floatval() on $order->getBaseGrandTotal().

Tested scenarios

  • manual full capture with floating points from Adyen CA
  • manual full capture with int from Adyen CA
  • manual partial capture with floating points from Adyen CA
  • manual partial capture with int from Adyen CA

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants