[ECP-9172] Solving Full Capture for Partial Payments #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
RokPopov
previously approved these changes
May 13, 2024
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
reviewed
May 13, 2024
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
candemiralp
previously approved these changes
May 13, 2024
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
RokPopov
approved these changes
May 13, 2024
khushboo-singhvi
had a problem deploying
to
internal
GitHub Actions
Failure
Merged
|
candemiralp
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With current implementation, there were no capture requests being sent for partial payments. The reason was idempotency key was not being sent correctly for all the partial payments and therefore we were receiving the last payment method captures only. This PR solves the issue by sending correct idempotency key for all the payment methods.
Tested scenarios
Single Giftcard, multiple giftcards, single CC, giftcard+creditcard
Fixes