-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Update documentation after merchantAccount got removed from Config for NodeJS implementation #609
Comments
Hi @smafre, I've just checked and looks like the config config.merchantAccount = "someMerchantAccount" and later on: checkout.payment({ ..., merchantAccount: config.merchantAccount }) And this is helpful if you need to switch between merchant accounts because you just need to change the value in one place. With that said, I'll have to revert the changes to the |
But why do we even have to specify the merchantAccount in the requests, when we've already set it up in the config? Thats the part I don't quite understand. If we've set the merchantAccount in the Config, which is used in Client, which is used in the CheckoutAPI, we should have access to it in the implementation of the .payment()-function. So we still specify the merchantAccount twice (kind of). |
We believe it's better to leave this choice to whoever is implementing the request than checking which requests contains the Again, the
The I understand it can be a bit frustrating to repeat this information in some places, but it's a trade-off which we believe is worthy. |
Ok, got it :) So I can choose to only specify the merchantAccount in my requests, and leave it empty in the config if I choose to do so. Thanks for the info and for getting back to me so fast 👍 |
Anytime, @smafre! |
The documentation needs to be updated after merchantAccount got removed from Config in PR #590. (https://docs.adyen.com/checkout/drop-in-web and maybe other places I don't know about).
The text was updated successfully, but these errors were encountered: