Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EXPIRE webhook #1315

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add missing EXPIRE webhook #1315

merged 2 commits into from
Feb 2, 2024

Conversation

witoszekdev
Copy link
Contributor

@witoszekdev witoszekdev commented Jan 25, 2024

Description
This PR adds missing EXPIRE webhook event type to NotificationRequestItem.EventCodeEnum enum.

Docs: https://docs.adyen.com/api-explorer/Webhooks/1/post/EXPIRE

@witoszekdev witoszekdev requested a review from a team as a code owner January 25, 2024 15:58
@wboereboom
Copy link
Contributor

Hi @witoszekdev ,

thanks for contributing to our Library.
Unfortunately all types are generated automatically, and your changes would be overwritten.
I'll inform internally as to why this type is not part of our API specification, and act accordingly.

Kind Regards,
Wouter
Adyen

@wboereboom
Copy link
Contributor

Hi @witoszekdev,

Disregard what I said before, we are not yet using the auto-generated models for Webhooks.
your PR looks good to me. I'll go ahead and merge.
Thanks for contributing! 💚

Kind Regards,
Wouter
Adyen

@wboereboom wboereboom enabled auto-merge (squash) February 2, 2024 15:10
@wboereboom wboereboom merged commit db357b5 into Adyen:main Feb 2, 2024
2 of 6 checks passed
@witoszekdev witoszekdev deleted the add-missing-expire-webhook branch February 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants