Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all services #1328

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Update all services #1328

merged 3 commits into from
Mar 8, 2024

Conversation

AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Feb 22, 2024

OpenAPI spec or templates produced changes on 27-02-2024 by commit.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner February 22, 2024 13:02
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 3 times, most recently from b89bbd9 to e9d1995 Compare March 1, 2024 12:49
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 12 times, most recently from 69892e8 to c847442 Compare March 6, 2024 13:34
@DjoykeAbyah DjoykeAbyah added the Breaking change This change introduces breaking changes label Mar 7, 2024
@DjoykeAbyah
Copy link
Contributor

⚠️ Classname change and some field name changes ⚠️

Changed from PINFunctionalityApi to ManageCardPINApi

DjoykeAbyah
DjoykeAbyah previously approved these changes Mar 7, 2024
@@ -8,6 +8,7 @@
*/

import { AddressRequirement } from './addressRequirement';
import { AddressRequirement | AmountMinMaxRequirement | BankAccountIdentificationTypeRequirement | PaymentInstrumentRequirement } from './addressRequirement | AmountMinMaxRequirement | BankAccountIdentificationTypeRequirement | PaymentInstrumentRequirement';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wboereboom @DjoykeAbyah such a weird this..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-_-'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it clashes with line 10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a generator issue:
OpenAPITools/openapi-generator#15384

@naseemkullah
Copy link

Any ETA of when this will be released? need to use terminalInstructions.adyenAppRestart for terminal-settings.
IF not any suggested workaround?

I've tried this but see no terminalInstructions in the response, so unclear if it works:

 await mgmtApi.TerminalSettingsStoreLevelApi.updateTerminalSettingsByStoreId(
      storeId,
      {
        ...terminalSettings,
        terminalInstructions: {adyenAppRestart: true},
      } as TerminalSettings
    );

@wboereboom wboereboom added Feature New feature or request and removed Breaking change This change introduces breaking changes labels Mar 8, 2024
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wboereboom
Copy link
Contributor

Hi @naseemkullah ,
Sorry for the inconvenience. We're dealing with some hiccups in code generation as you might have been able to tell. We're working around this manually so we can provide you the necessary fixes before the end of the day.

Kind Regards,
Wouter
Adyen

@wboereboom wboereboom enabled auto-merge (squash) March 8, 2024 10:19
@wboereboom wboereboom merged commit 01ca16f into main Mar 8, 2024
9 of 10 checks passed
@wboereboom wboereboom deleted the sdk-automation/models branch March 8, 2024 10:20
@naseemkullah
Copy link

Hi @naseemkullah ,

Sorry for the inconvenience. We're dealing with some hiccups in code generation as you might have been able to tell. We're working around this manually so we can provide you the necessary fixes before the end of the day.

Kind Regards,

Wouter

Adyen

Amazing - much appreciated! 🙏

Good luck with the tooling issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants