Wrong parameter type in metadata functions

[GunniBusch]

In this function, the parameter type also includes null. but it should not be null.

Could there be just no action if it is null?

    /**
     * Sets metadata
     *
     * @param array<string,string>|null $metadata Metadata consists of entries, each of which includes a key and a value. Limits: * Maximum 20 key-value pairs per request. * Maximum 20 characters per key. * Maximum 80 characters per value.
     *
     * @return self
     */
    public function setMetadata($metadata)
    {
        if (is_null($metadata)) {
            throw new \InvalidArgumentException('non-nullable metadata cannot be null');
        }
        $this->container['metadata'] = $metadata;

        return $this;
    }

PS: it is in all setMetadata functions.

[jillingk]

Hi @GunniBusch,

We've just merged a fix that removes the null check. We realised that the serialiser will omit these during serialisation anyways so we simply use null values to remove fields on the setter. This means null is allowed as means to remove pre-filled fields. Hope that makes sense and answers your question.

Best, Jilling
Adyen

[github-actions]

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs.

[github-actions]

This issue was closed due to inactivity. Please reopen if you still encounter this problem or have more information to add.