Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong SessionConfiguration interface #418

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

onooma
Copy link
Contributor

@onooma onooma commented Apr 15, 2024

Summary

The SessionConfiguartion interface signature is differs from what native modules expect.

The native modules expect id but SessionConfiguration contains sessionID as you can see here:

guard let id = sessionModelJSON["id"] as? String, let data = sessionModelJSON["sessionData"] as? String else {

Tested scenarios

Fixed issue:

@descorp
Copy link
Contributor

descorp commented Apr 16, 2024

Thanks @onooma 💚

@descorp descorp merged commit ffb3720 into Adyen:develop Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants