Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adapter_options to client #169

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add adapter_options to client #169

merged 3 commits into from
Sep 25, 2023

Conversation

ollym
Copy link
Contributor

@ollym ollym commented Aug 28, 2023

For use with a custom Faraday adapter

@ollym ollym requested a review from a team as a code owner August 28, 2023 02:22
@wboereboom
Copy link
Contributor

Hi @ollym,

Thanks for contributing.
Could you add a test to the client spec to verify validity?
LGTM otherwise!

Kind Regards,
Wouter
Adyen

@ollym
Copy link
Contributor Author

ollym commented Aug 28, 2023

@wboereboom how do you want to do it? There's even no tests for adapter currently

@ollym
Copy link
Contributor Author

ollym commented Sep 14, 2023

@wboereboom ?

@jillingk
Copy link
Contributor

Quickly resolved conflicts, we can safely merge this imo.

@AlexandrosMor AlexandrosMor merged commit ccee71f into Adyen:develop Sep 25, 2023
7 checks passed
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Sep 25, 2023
Merged
@jotolo jotolo mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosMor AlexandrosMor AlexandrosMor approved these changes

@jillingk jillingk jillingk approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ollym @wboereboom @jillingk @AlexandrosMor