Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-7980] Update NotificationEntity definitions and exception handling for notification processing #353

Merged
merged 3 commits into from Feb 20, 2023

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Feb 16, 2023

Summary

  • NotificationEntity definitions updated to keep the consistency with the database.
  • Exception handling logic updated. Nullable fields won't throw any exception while webhook processing.
  • Type declarations added to modified classes.
  • isReportNotification() check removed while receiving notification. All of the received notifications will be stored in the database to allow merchants for further custom implementation of the webhooks.

Tested scenarios

  • REPORT_AVAILABLE notification w/wo merchant_reference
  • AUTHORISATION notification
  • REFUND notification

Fixes #345

@candemiralp candemiralp merged commit 4b45440 into develop Feb 20, 2023
@candemiralp candemiralp deleted the PW-7980 branch February 20, 2023 09:30
@candemiralp candemiralp mentioned this pull request Mar 6, 2023
@candemiralp candemiralp added the Fix Indicates a bug fix label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PW-7980] MerchantReference can be NULL for notifications
3 participants