Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Util/Currency into Shopware6 project #455

Merged
merged 15 commits into from
Apr 15, 2024
Merged

Moved Util/Currency into Shopware6 project #455

merged 15 commits into from
Apr 15, 2024

Conversation

SushmitaThakur
Copy link
Contributor

Currency.php was the only utility function being used from the library. Duplicated Currency Util file in Shopware6 repository (src/Util) and replaced the usage.

@SushmitaThakur SushmitaThakur requested a review from a team as a code owner February 5, 2024 09:23
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

peterojo
peterojo previously approved these changes Mar 6, 2024
RokPopov
RokPopov previously approved these changes Apr 10, 2024
candemiralp
candemiralp previously approved these changes Apr 15, 2024
@candemiralp candemiralp dismissed stale reviews from RokPopov, peterojo, and themself via 50ce940 April 15, 2024 13:38
candemiralp
candemiralp previously approved these changes Apr 15, 2024
RokPopov
RokPopov previously approved these changes Apr 15, 2024
@candemiralp candemiralp dismissed stale reviews from RokPopov and themself via 9ee0699 April 15, 2024 13:49
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@candemiralp candemiralp merged commit 6df23d9 into develop Apr 15, 2024
11 of 12 checks passed
@candemiralp candemiralp deleted the ECP-8839 branch April 15, 2024 13:50
@RokPopov RokPopov mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants