Fix recursion error for checkout order route #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
FrontendProxyController::checkoutOrder()
the whole order entity is being put in aJsonResponse
. If that order has bidirectional associations (for example transactions which also have a reference back to the order, and thus back to the transactions and back to the order etc...) then theJsonResponse
object will throw an error: "Recursion detected"Tested scenarios
Just load an order with some bidirectional associations in some subscriber that's triggered on checkout.
Fixed issue: No issue has been made
Solution
The JS success callback that uses the checkout route response only used the id, so no need to send the whole entity. Just send the id, and that's it.