Feature/excluding brands from UI #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontains an excluded brand
…a binLookup result contains an excluded brand
…entMethodItem in Dropin; and from brands shown under Card Number
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
jobsturm
as code owners
|
Size Change: +939 B (0%) Total Size: 847 kB
ℹ️ View Unchanged
|
ribeiroguilherme
approved these changes
Sep 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ticket states: "Remove US debit related payment method logos on drop-in" - basically some US debit cards should never appear in the UI or be revealed to the shopper.
Apparently this can't be dealt with in the b/e since merchants still want to see these brands in the
/paymentMethods&/binLookupresponses.So... we have a hard-coded* array of brands that need to be excluded from the UI, meaning:
brandin thepaymentMethoddataTested scenarios
New unit & e2e tests added to test the four scenarios, above
All tests pass
Fixed issue: FOC-61989
Note:
*this is currently a hard-coded list of 4 card brands and is expected to stay this way
However if this number was to grow in the future we should consider that it should be set elsewhere - perhaps as a property in the
configurationobject that can be returned by the b/e on the Credit card PM object