Feature: Validation Message with complex Validations #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarDevDuck
requested review from
marcperez,
pabloai and
sponglord
as code owners
|
Converting to draft to avoid merging it accidentally. |
pabloai
reviewed
Aug 19, 2020
src/components/Econtext/components/EcontextInput/EcontextInput.tsx
Outdated
Show resolved
Hide resolved
pabloai
reviewed
Aug 19, 2020
pabloai
reviewed
Aug 19, 2020
pabloai
requested changes
Aug 19, 2020
sponglord
reviewed
Aug 19, 2020
added 5 commits
August 25, 2020 16:32
- Using `true` when an errorMessage is not required is sufficient
|
Kudos, SonarCloud Quality Gate passed!
|
pabloai
approved these changes
Aug 25, 2020
|
Merging PR. Thanks for your contribution @DarDevDuck! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complex Validations should show validation error messages to help user identify issue. For instance, issue FOC-32362 which requires that
econtexttelephoneNumberfields must be 10 or 11 digits.Also enhanced
dateOfBirthvalidations to provide error messages to users that theyMust be at least 18 years oldAffected Components
Doku,Econtext,OpenInvoiceTested scenarios
dateOfBirthvalidation message forOpenInvoicewhen age is less than 18 years old.telephoneNumbervalidations foreContextflowsRelates to issue: FOC-32362