Added aria & a11y attributes #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usable" attr to payment method icons
|
Kudos, SonarCloud Quality Gate passed!
|
marcperez
approved these changes
Aug 28, 2020
pabloai
approved these changes
Aug 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usable" attr to payment method icons
Summary
Added aria attribute![]()
in payment method icon
aria-live="polite"to error spans.Added
aria-hidden="true"to span that holds payment method icon in Dropin.Added IE related
focusable="false"attr toTested scenarios
Tested with Mac VoiceOver utility
Fixed issue: Addresses issues in FOC-33752 (namely points 2i & 2j)