fix: display date and time in some vouchers #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 3b2c73c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +437 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
|
How did you test that this works with expiration dates/times from different time zones? |
sponglord
reviewed
Apr 8, 2024
| @@ -25,7 +25,7 @@ export default function DragonpayVoucherResult(props: DragonpayVoucherResultProp | |||
| surcharge={surcharge && i18n.amount(surcharge.value, surcharge.currency)} | |||
| voucherDetails={ | |||
| [ | |||
| { label: i18n.get('voucher.expirationDate'), value: i18n.date(expiresAt) }, | |||
| { label: i18n.get('voucher.expirationDate'), value: i18n.dateTime(expiresAt) }, | |||
There was a problem hiding this comment.
Are we sure that the expiresAt will always be a date & time value? What happens if it's still just a date only?
There was a problem hiding this comment.
It will always be there since the backend is sending a ISO date. It could be wrong but then it's something on backend/acquiring side.
sponglord
approved these changes
Apr 8, 2024
Merged
m1aw
added a commit
that referenced
this pull request
Apr 15, 2024
* fix: display date and time in some vouhcers * fix imports * fix locale issue * adds safety checks (cherry picked from commit 57bacc7)
m1aw
added a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some voucher like Econtext and Dragon pay we shuold display expiration time together with the date.
Created a new i18n function to format dateTime. Also make a tittle change to make sure we are not creating a new formatter every time as it's a slow operation (according MDN).
Tested scenarios
Fixed issue:
COWEB-1297, COWEB-1359