Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show the instant payments when they are the only supported PMs #2629

Merged
merged 2 commits into from Apr 8, 2024

Conversation

longyulongyu
Copy link
Contributor

Summary

Fix the bug that the drop-in is not rendered when there are only instant payments.

Tested scenarios

To reproduce:

  • For the manual flow, pass the following to the checkout config
paymentMethodsResponse: {
            paymentMethods: [
                {
                    configuration: {
                        merchantId: '12345678',
                        gatewayMerchantId: 'testMerchant'
                    },
                    name: 'Google Pay',
                    type: 'paywithgoogle'
                }
            ]
        },
  • Specify the instantPaymentTypes: ['paywithgoogle'] in the drop-in config
  • The drop-in is not rendered

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: ffd8001

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Size Change: +181 B (0%)

Total Size: 1.14 MB

Filename Size Change
packages/lib/dist/adyen.js 302 kB +49 B (0%)
packages/lib/dist/cjs/index.js 263 kB +49 B (0%)
packages/lib/dist/es.modern/index.js 125 kB +36 B (0%)
packages/lib/dist/es/index.js 146 kB +47 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.95 kB
packages/lib/dist/es.modern/cs-CZ.js 6.19 kB
packages/lib/dist/es.modern/da-DK.js 5.62 kB
packages/lib/dist/es.modern/de-DE.js 6.09 kB
packages/lib/dist/es.modern/el-GR.js 7.91 kB
packages/lib/dist/es.modern/es-ES.js 5.73 kB
packages/lib/dist/es.modern/fi-FI.js 5.73 kB
packages/lib/dist/es.modern/fr-FR.js 5.96 kB
packages/lib/dist/es.modern/hr-HR.js 5.99 kB
packages/lib/dist/es.modern/hu-HU.js 6.27 kB
packages/lib/dist/es.modern/it-IT.js 5.81 kB
packages/lib/dist/es.modern/ja-JP.js 6.69 kB
packages/lib/dist/es.modern/ko-KR.js 6.32 kB
packages/lib/dist/es.modern/nl-NL.js 5.76 kB
packages/lib/dist/es.modern/no-NO.js 5.58 kB
packages/lib/dist/es.modern/pl-PL.js 6.27 kB
packages/lib/dist/es.modern/pt-BR.js 5.78 kB
packages/lib/dist/es.modern/pt-PT.js 5.91 kB
packages/lib/dist/es.modern/ro-RO.js 6.05 kB
packages/lib/dist/es.modern/ru-RU.js 7.39 kB
packages/lib/dist/es.modern/sk-SK.js 6.36 kB
packages/lib/dist/es.modern/sl-SI.js 5.91 kB
packages/lib/dist/es.modern/sv-SE.js 5.59 kB
packages/lib/dist/es.modern/zh-CN.js 6.13 kB
packages/lib/dist/es.modern/zh-TW.js 6.22 kB
packages/lib/dist/es/ar.js 6.95 kB
packages/lib/dist/es/cs-CZ.js 6.19 kB
packages/lib/dist/es/da-DK.js 5.62 kB
packages/lib/dist/es/de-DE.js 6.09 kB
packages/lib/dist/es/el-GR.js 7.91 kB
packages/lib/dist/es/es-ES.js 5.73 kB
packages/lib/dist/es/fi-FI.js 5.73 kB
packages/lib/dist/es/fr-FR.js 5.96 kB
packages/lib/dist/es/hr-HR.js 5.99 kB
packages/lib/dist/es/hu-HU.js 6.27 kB
packages/lib/dist/es/it-IT.js 5.81 kB
packages/lib/dist/es/ja-JP.js 6.69 kB
packages/lib/dist/es/ko-KR.js 6.32 kB
packages/lib/dist/es/nl-NL.js 5.76 kB
packages/lib/dist/es/no-NO.js 5.58 kB
packages/lib/dist/es/pl-PL.js 6.27 kB
packages/lib/dist/es/pt-BR.js 5.78 kB
packages/lib/dist/es/pt-PT.js 5.91 kB
packages/lib/dist/es/ro-RO.js 6.05 kB
packages/lib/dist/es/ru-RU.js 7.39 kB
packages/lib/dist/es/sk-SK.js 6.36 kB
packages/lib/dist/es/sl-SI.js 5.91 kB
packages/lib/dist/es/sv-SE.js 5.59 kB
packages/lib/dist/es/zh-CN.js 6.13 kB
packages/lib/dist/es/zh-TW.js 6.22 kB

compressed-size-action

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ribeiroguilherme ribeiroguilherme merged commit 17f15e9 into main Apr 8, 2024
12 of 13 checks passed
@ribeiroguilherme ribeiroguilherme deleted the fix-instant-pm-not-shown branch April 8, 2024 09:56
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants