Fix: ANCV ignoring existing orders & not working as intended via custom payButton #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: fb89ae8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +260 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ribeiroguilherme
approved these changes
Apr 23, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR was original intended to fix a bug in ANCV where it always made new
ordercalls. This was an issue if ANCV was not the first partial payment method, ie: Giftcard -> ANCV, or ANCV -> ANCV.To fix this issue a check was introduce to use an existing order. The problem is that in the process it was notice that passing a different Class instance function to
payButtonwas causing it to dereferencethis.propsand use the one frompayButtoninstead ofUIElement/ANCVElement.The solution was to use
submitin thepayButton. The problem is thatsubmitonly really gets reimplemented in express payment methods. This also lead to realise that contrary to what we do in gift card, this is probably the most correct way. It was because of this also necessary to changeonSubmitaccess modifier, from private, to protected. This makes so we can useonSubmitimplementation on the component. I believe this change is more in line what we are doing in V6.Possible further discussion can be held on this point about
.submit()being more consistent for partial payment methods.Tested scenarios
Fixed issue: