Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions - Replacing "Invalid ClientKey" error message with more meaningful error #2706

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

ribeiroguilherme
Copy link
Contributor

Summary

  • The error message "Invalid ClientKey" is misleading. Now we are returning more meaningful error message containing the actual error in it;
  • The full error object is assigned to the AdyenCheckoutError property cause and it can be inspected properly;

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 0e8d100

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: -23 B (0%)

Total Size: 1.16 MB

Filename Size Change
packages/lib/dist/adyen.js 306 kB -2 B (0%)
packages/lib/dist/cjs/index.js 266 kB -7 B (0%)
packages/lib/dist/es.modern/index.js 127 kB -7 B (-0.01%)
packages/lib/dist/es/index.js 148 kB -7 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 7.13 kB
packages/lib/dist/es.modern/cs-CZ.js 6.27 kB
packages/lib/dist/es.modern/da-DK.js 5.68 kB
packages/lib/dist/es.modern/de-DE.js 6.17 kB
packages/lib/dist/es.modern/el-GR.js 8.03 kB
packages/lib/dist/es.modern/es-ES.js 5.81 kB
packages/lib/dist/es.modern/fi-FI.js 5.81 kB
packages/lib/dist/es.modern/fr-FR.js 6.04 kB
packages/lib/dist/es.modern/hr-HR.js 6.08 kB
packages/lib/dist/es.modern/hu-HU.js 6.36 kB
packages/lib/dist/es.modern/it-IT.js 5.88 kB
packages/lib/dist/es.modern/ja-JP.js 6.81 kB
packages/lib/dist/es.modern/ko-KR.js 6.45 kB
packages/lib/dist/es.modern/nl-NL.js 5.83 kB
packages/lib/dist/es.modern/no-NO.js 5.68 kB
packages/lib/dist/es.modern/pl-PL.js 6.32 kB
packages/lib/dist/es.modern/pt-BR.js 5.86 kB
packages/lib/dist/es.modern/pt-PT.js 5.98 kB
packages/lib/dist/es.modern/ro-RO.js 6.13 kB
packages/lib/dist/es.modern/ru-RU.js 7.5 kB
packages/lib/dist/es.modern/sk-SK.js 6.46 kB
packages/lib/dist/es.modern/sl-SI.js 5.98 kB
packages/lib/dist/es.modern/sv-SE.js 5.66 kB
packages/lib/dist/es.modern/zh-CN.js 6.25 kB
packages/lib/dist/es.modern/zh-TW.js 6.35 kB
packages/lib/dist/es/ar.js 7.13 kB
packages/lib/dist/es/cs-CZ.js 6.27 kB
packages/lib/dist/es/da-DK.js 5.68 kB
packages/lib/dist/es/de-DE.js 6.17 kB
packages/lib/dist/es/el-GR.js 8.03 kB
packages/lib/dist/es/es-ES.js 5.81 kB
packages/lib/dist/es/fi-FI.js 5.81 kB
packages/lib/dist/es/fr-FR.js 6.04 kB
packages/lib/dist/es/hr-HR.js 6.08 kB
packages/lib/dist/es/hu-HU.js 6.36 kB
packages/lib/dist/es/it-IT.js 5.88 kB
packages/lib/dist/es/ja-JP.js 6.81 kB
packages/lib/dist/es/ko-KR.js 6.45 kB
packages/lib/dist/es/nl-NL.js 5.83 kB
packages/lib/dist/es/no-NO.js 5.68 kB
packages/lib/dist/es/pl-PL.js 6.32 kB
packages/lib/dist/es/pt-BR.js 5.86 kB
packages/lib/dist/es/pt-PT.js 5.98 kB
packages/lib/dist/es/ro-RO.js 6.13 kB
packages/lib/dist/es/ru-RU.js 7.5 kB
packages/lib/dist/es/sk-SK.js 6.46 kB
packages/lib/dist/es/sl-SI.js 5.98 kB
packages/lib/dist/es/sv-SE.js 5.66 kB
packages/lib/dist/es/zh-CN.js 6.25 kB
packages/lib/dist/es/zh-TW.js 6.35 kB

compressed-size-action

Copy link

sonarcloud bot commented Jun 10, 2024

@ribeiroguilherme ribeiroguilherme merged commit 16b4e61 into main Jun 11, 2024
12 checks passed
@ribeiroguilherme ribeiroguilherme deleted the removing-invalid-key-error-message branch June 11, 2024 07:57
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
ribeiroguilherme added a commit that referenced this pull request Jun 11, 2024
…ingful error (#2706)

* removing invalid clientkey error

* changeset
ribeiroguilherme added a commit that referenced this pull request Jun 12, 2024
…ingful error (#2706) (#2710)

* removing invalid clientkey error

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants