Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null value issues on PaymentMethodsResponse #505

Merged
merged 1 commit into from Nov 12, 2020

Conversation

marcperez
Copy link
Member

Summary

Fixes an issue where initialization could fail if a paymentMethodsResponse value would contain null values.

Tested scenarios

  • paymentMethodsResponse.paymentMethods = null defaults to an empty array
  • paymentMethodsResponse.storedPaymentMethods = null defaults to an empty array

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Size Change: -14 B (0%)

Total Size: 124 kB

Filename Size Change
packages/lib/dist/adyen.js 124 kB -14 B (0%)

compressed-size-action

@marcperez marcperez merged commit d876b38 into master Nov 12, 2020
@marcperez marcperez deleted the fix/paymentMethodsResponse-null-values branch November 12, 2020 13:36
@marcperez marcperez mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants