Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gift card error messages #507

Merged
merged 2 commits into from Nov 13, 2020
Merged

Conversation

marcperez
Copy link
Member

Summary

Handle more error types on the balance check step in the new Gift card flow.

Tested scenarios

  • An error is shown when a gift card has no balance
  • An error is shown when a gift card has balance in a different currency
  • An error is shown when a gift card number can't be found

@marcperez marcperez marked this pull request as ready for review November 12, 2020 16:10
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Size Change: +276 B (0%)

Total Size: 125 kB

Filename Size Change
packages/lib/dist/adyen.js 125 kB +276 B (0%)

compressed-size-action

@marcperez marcperez merged commit d33b4c4 into master Nov 13, 2020
@marcperez marcperez deleted the fix/improve-giftcard-errors branch November 13, 2020 13:10
@marcperez marcperez mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants