Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with PayPal Credit button styles. #545

Merged
merged 1 commit into from Nov 25, 2020

Conversation

pabloai
Copy link
Contributor

@pabloai pabloai commented Nov 25, 2020

Summary

Fixing an issue with the style.color containing unsupported values for PayPal Credit after an extra check was added on PayPal's side to always default to color gold.

Tested scenarios

Tested all possible values for the color property.

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Size Change: +98 B (0%)

Total Size: 125 kB

Filename Size Change
packages/lib/dist/adyen.js 125 kB +98 B (0%)

compressed-size-action

@pabloai pabloai merged commit a831c7c into master Nov 25, 2020
@pabloai pabloai deleted the fix/paypal-credit-styles branch November 25, 2020 14:24
@marcperez marcperez mentioned this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants