Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new bcmc bins #648

Merged
merged 1 commit into from Jan 8, 2021
Merged

Conversation

sponglord
Copy link
Contributor

Summary

Upped SF version to 3.2.8 - where, inbuilt check for wrong number in single-branded card, is removed.
This check was failing to recognise new BCMC bins and throwing an error which then prevented /binLookup from working.
So in the case of single-branded card components i.e. a card component hard typed to only accept a single brand e.g. 'bcmc' - securedFields now no longer try to detect what brand the shopper is actually typing to see if it is correct or not; instead relying on binLookup to do this

Tested scenarios

All test still pass.
sf v3.2.8 is available on Test & Live
New bcmc bins are recognised
Typin a non-bcmc card into a bcmc card component gives the expected "unsupported card" error

Fixed issue: COWEB-869

@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

Size Change: -48 B (0%)

Total Size: 128 kB

Filename Size Change
packages/lib/dist/adyen.js 128 kB -48 B (0%)

compressed-size-action

@sponglord sponglord merged commit 470c72d into master Jan 8, 2021
@sponglord sponglord deleted the fix/allow_bin_lookup_for_new_bcmc_bins branch January 8, 2021 13:57
@marcperez marcperez mentioned this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants