Ensure iDeal selected bank icon has a height for IE11 #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforcing a height and width of auto on this icon causes the icon to not have a body on IE11. Setting the fixed height ensures the icon is always visible.
Lesleyvdp
requested review from
marcperez,
pabloai,
shernaz and
sponglord
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
pabloai
approved these changes
Jan 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforcing a height and width of auto on this icon causes the icon to not have a body on IE11. Setting the fixed height ensures the icon is always visible.
It solves the iDeal selected bank icon not appearing on IE11.
Tested scenarios
Fixed issue: #674