Feature/handling v2 bin lookup #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai and
shernaz
as code owners
|
Size Change: +192 B (0%) Total Size: 145 kB
|
marcperez
reviewed
Jan 21, 2021
… enableLuhnCheck). Added handler for error object generated when the whole binLookup fails
marcperez
reviewed
Jan 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
marcperez
approved these changes
Jan 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes needed to use and handle the v2 /binLookup
Tested scenarios
Added tests.
All tests, old & new, unit & e2e, pass