Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enabling new 3DS2 flow #729

Merged
merged 11 commits into from
Feb 8, 2021
Merged

Conversation

sponglord
Copy link
Contributor

@sponglord sponglord commented Feb 8, 2021

Summary

Code now in place to work fully or partially with the new 3DS2 flow.

  • A full flow will occur when the merchant is on API v67 - then the /payments response will include a new action with type threeDS2, fingerprinting and the processing of the fingerprint result will occur automatically (no merchant involvement or call to /details required) via /submitThreeDS2Fingerprint, and the process will conclude after the challenge with the usual call to /details.
  • A partial flow will see the /payments response still using the old action with type threeDS2Fingerprint but subsequent steps will be the same as for the full flow.

Tested scenarios

Tested scenarios for:

  • Frictionless flow (no challenge)
  • Full flow (fingerprint & challenge)
  • Redirect flow
  • Challenge-only flow
  • threeDS2InMDFlow

e2e tests exist for the first 4 scenarios

Relates to issue: DEV-31189

@sponglord sponglord changed the title Feature/enabling new 3 ds2 flow Feature/enabling new 3DS2 flow Feb 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

Size Change: +272 B (0%)

Total Size: 146 kB

Filename Size Change
packages/lib/dist/adyen.js 146 kB +272 B (0%)

compressed-size-action

@sponglord sponglord merged commit 62fa450 into master Feb 8, 2021
@sponglord sponglord deleted the feature/enabling_new_3DS2_flow branch February 8, 2021 13:49
@marcperez marcperez mentioned this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants