Brand (in PaymentMethod data) is reset after a failed binLookup #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When card information is entered, and recognised by
/binLookup
, abrand
property is set which will ultimately end up in thepaymentMethod
data submitted to the/payments
endpoint.However if the shopper then pastes a second card number directly into the field - the
paymentMethod.brand
will remain set to the previous card brand.This PR ensures that if
/binLookup
fails to recognize the BIN for a second card then thisbrand
property is reset.Tested scenarios
Various e2e tests included to test the above scenario.
Also testing:
Fixed issue: COWEB-937