Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positionHolderNameOnTop for the Card component #891

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

pabloai
Copy link
Contributor

@pabloai pabloai commented Mar 26, 2021

Add option to position the holder name field on top of the Card component.

Summary

Users have been recurrently asking for the possibility of placing the holder name field at the top of the Card component. After discussing it with the some of the Frontend team and with some of our designers, we've decided to allow this.
Therefore we're adding a positionHolderNameOnTop option which accepts a boolean and it's false by default.

Tested scenarios

Added test to check if the positioning is working

Fixed issue: #882

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2021

Size Change: +110 B (0%)

Total Size: 460 kB

Filename Size Change
packages/lib/dist/adyen.js 147 kB +34 B (0%)
packages/lib/dist/cjs/index.js 144 kB +34 B (0%)
packages/lib/dist/es/index.js 83 kB +42 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/lib/dist/es/cs-CZ.js 3.8 kB 0 B
packages/lib/dist/es/da-DK.js 3.36 kB 0 B
packages/lib/dist/es/de-DE.js 3.76 kB 0 B
packages/lib/dist/es/el-GR.js 4.72 kB 0 B
packages/lib/dist/es/es-ES.js 3.54 kB 0 B
packages/lib/dist/es/fi-FI.js 3.55 kB 0 B
packages/lib/dist/es/fr-FR.js 3.68 kB 0 B
packages/lib/dist/es/hr-HR.js 3.58 kB 0 B
packages/lib/dist/es/hu-HU.js 3.78 kB 0 B
packages/lib/dist/es/it-IT.js 3.49 kB 0 B
packages/lib/dist/es/ja-JP.js 4.21 kB 0 B
packages/lib/dist/es/ko-KR.js 3.84 kB 0 B
packages/lib/dist/es/nl-NL.js 3.55 kB 0 B
packages/lib/dist/es/no-NO.js 3.37 kB 0 B
packages/lib/dist/es/pl-PL.js 3.84 kB 0 B
packages/lib/dist/es/pt-BR.js 3.53 kB 0 B
packages/lib/dist/es/ro-RO.js 3.71 kB 0 B
packages/lib/dist/es/ru-RU.js 4.48 kB 0 B
packages/lib/dist/es/sk-SK.js 3.86 kB 0 B
packages/lib/dist/es/sl-SI.js 3.46 kB 0 B
packages/lib/dist/es/sv-SE.js 3.5 kB 0 B
packages/lib/dist/es/zh-CN.js 3.75 kB 0 B
packages/lib/dist/es/zh-TW.js 3.91 kB 0 B

compressed-size-action

@sponglord sponglord self-requested a review March 26, 2021 10:08
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pabloai pabloai merged commit b499368 into master Mar 26, 2021
@pabloai pabloai deleted the feature/position-holdername-on-top branch March 26, 2021 12:13
@sponglord sponglord mentioned this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants