Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for clientKey and fallback to originKey on CSF #95

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Check for clientKey and fallback to originKey on CSF #95

merged 1 commit into from
Jul 8, 2020

Conversation

marcperez
Copy link
Member

Summary

  • Check for clientKey and fallback to originKey on CSF

Tested scenarios

  • Card component works with clientKey and originKey
  • Card component works with only clientKey
  • Card component works with only originKey

@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcperez marcperez merged commit 1f2dba4 into master Jul 8, 2020
@marcperez marcperez deleted the fix/clientKey-check branch July 8, 2020 10:10
@marcperez marcperez mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloai pabloai pabloai approved these changes

@sponglord sponglord sponglord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcperez @pabloai @sponglord