Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix axis grid lines not updating on size change #138

Conversation

joao-m-santos
Copy link
Contributor

Fixes #127

📝 Description

Added containerSize to watch triggers for re-rendering ticks

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner January 17, 2023 12:46
@joao-m-santos joao-m-santos self-assigned this Jan 17, 2023
@joao-m-santos joao-m-santos linked an issue Jan 17, 2023 that may be closed by this pull request
5 tasks
@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 03a5a4e
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/63c7b70cab029700089596db
😎 Deploy Preview https://deploy-preview-138--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vivy27
vivy27 previously approved these changes Jan 17, 2023
Lucas1981
Lucas1981 previously approved these changes Jan 17, 2023
@joao-m-santos joao-m-santos force-pushed the 137-axis-grid-lines-are-not-reactive-to-containersize-change branch from f9b53b4 to 8765014 Compare January 17, 2023 13:54
@joao-m-santos joao-m-santos dismissed stale reviews from Lucas1981 and vivy27 via 8765014 January 18, 2023 09:08
@joao-m-santos joao-m-santos merged commit 9d178d6 into main Jan 18, 2023
@joao-m-santos joao-m-santos deleted the 137-axis-grid-lines-are-not-reactive-to-containersize-change branch February 1, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axis grid lines are not reactive to containerSize change Axis labels don't have background in some cases
4 participants