Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 fix broken test in github action #19

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

vivy27
Copy link
Contributor

@vivy27 vivy27 commented Oct 17, 2022

Relates to #

📝 Description

change jest config ext to .cjs as type module in package.json allows es module by default

Add a brief description

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@vivy27 vivy27 requested a review from a team as a code owner October 17, 2022 13:19
joao-m-santos
joao-m-santos previously approved these changes Oct 17, 2022
@joao-m-santos joao-m-santos merged commit c40cd3a into main Oct 18, 2022
@joao-m-santos joao-m-santos deleted the 💚-fix-broken-test-in-github-action branch February 1, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants