Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

41 add option to set/remove chart background color #43

Merged
merged 1 commit into from
Oct 28, 2022
Merged

41 add option to set/remove chart background color #43

merged 1 commit into from
Oct 28, 2022

Conversation

joao-m-santos
Copy link
Contributor

@joao-m-santos joao-m-santos commented Oct 27, 2022 •
edited
Loading

Closes to #41

📝 Description

Added option to enable/disable transparentBackground property in lume-chart-container
Updated documentation (options table)

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos requested a review from a team as a code owner October 27, 2022 12:34
@joao-m-santos joao-m-santos self-assigned this Oct 27, 2022
@joao-m-santos joao-m-santos force-pushed the 41-add-option-to-setremove-chart-background-color branch from 8de8bf3 to fee8fe0 Compare October 28, 2022 07:27
@joao-m-santos joao-m-santos merged commit 78f6ac9 into main Oct 28, 2022
@joao-m-santos joao-m-santos deleted the 41-add-option-to-setremove-chart-background-color branch February 1, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivy27 vivy27 vivy27 approved these changes

@govind-srinidhi govind-srinidhi govind-srinidhi approved these changes

Assignees

@joao-m-santos joao-m-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joao-m-santos @vivy27 @govind-srinidhi