Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

droplet tool doesn't correct when screen have set to scale #73

Open
pureexe opened this issue Jun 11, 2018 · 5 comments
Open

droplet tool doesn't correct when screen have set to scale #73

pureexe opened this issue Jun 11, 2018 · 5 comments

Comments

@pureexe
Copy link

pureexe commented Jun 11, 2018

When you windows screen have set to scale in settings. droplet tool that use to get pixel color in video doesn't work correctly.

screenshot of bug.

@wangqr
Copy link

wangqr commented Nov 12, 2018

You can disable system-level DPI resize by right click on aegisub.exe -> properties -> compatibility -> change high dpi settings -> check "high dpi scaling override", and select "application" in the drop down menu.

@pureexe
Copy link
Author

pureexe commented Dec 7, 2018

Confirm that your method solves the problem.
but I hope aegisub next release will solve this problem.

@pureexe
Copy link
Author

pureexe commented Dec 7, 2018

I never work with wxWidgets before but look like the problem is around this line.

void OnMouse(wxMouseEvent &evt) {
int x = evt.GetX();
int y = evt.GetY();

and to fix might be change to this

void OnMouse(wxMouseEvent &evt) {
    double scale = GetContentScaleFactor();
    int x = evt.GetX() * scale;
    int y = evt.GetY() * scale;

a wxWidget reference that i just search on google.
https://docs.wxwidgets.org/3.0/classwx_window.html#a6f230d4db56d1d2ab364fe1491f2e9ba

@wangqr
Copy link

wangqr commented Dec 8, 2018

I believe that Aegisub is able to handle DPI scaling itself. And handling DPI scaling by application will give a much better/sharper look. Some text box size related issue is fixed in #37 or in my fork. Personally I set the DPI aware flag in manifest while compiling Aegisub on Windows, so DPI scaling is handled by Aegisub automatically without the need of overriding.

@pureexe
Copy link
Author

pureexe commented Dec 8, 2018

if it can fix easily from the manifest. I hope aegisub dev team will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants