Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching servers, players are counted as 2 players. #33

Closed
TheDeafCreeper opened this issue Aug 16, 2023 · 2 comments · Fixed by #35
Closed

When switching servers, players are counted as 2 players. #33

TheDeafCreeper opened this issue Aug 16, 2023 · 2 comments · Fixed by #35
Labels
bug Something isn't working patched The issue has been patched and should be fixed

Comments

@TheDeafCreeper
Copy link
Contributor

When a player is moved from one server to another, the target server's player count will increase by 2 instead of 1. This does not happen on first join.

The issue also corrects itself once the server resyncs.

@nathan-i-martin
Copy link
Contributor

nathan-i-martin commented Aug 17, 2023

Will take a look into this and see if it makes sense to fix. It's known that server count set by the proxy might not be correct (hence why the reruns system exists). Ultimately the proxy is only estimating player changes until it gets a sync packet.
Depending on what is causing the duplicate to occur this may or may not make sense to fix (since it'll ultimately resync anyways)

@nathan-i-martin nathan-i-martin added bug Something isn't working won't fix This will not be worked on labels Aug 17, 2023
@nathan-i-martin
Copy link
Contributor

I can't seem to find what might be causing this. If someone else is able to find it I'll be happy to go in and take care of it. Because of what I mentioned earlier this isn't something I'm willing to spend much time figuring out so for now I'm going to close this.

nathan-i-martin added a commit that referenced this issue Aug 31, 2023
@nathan-i-martin nathan-i-martin mentioned this issue Aug 31, 2023
@nathan-i-martin nathan-i-martin added patched The issue has been patched and should be fixed and removed won't fix This will not be worked on labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patched The issue has been patched and should be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants