Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the derive-visitor crate to replace our hand-written visitors #260

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Jun 17, 2024

This uses the clever derive_visitor crate instead of our handwritten visitors. I managed to replace all of our visitor needs with it.

This PR is more readable commit-by-commit. Fixes #249.

@Nadrieril Nadrieril requested a review from sonmarcho June 17, 2024 13:23
@Nadrieril
Copy link
Member Author

I'm a bit worried about the risk of stack overflow given that derive-visitor doesn't use ensure_sufficient_stack. I'm working on #122 to remove the main source of runaway recursion.

Copy link
Member

@sonmarcho sonmarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!
If we have a stack-overflow issue with one instantiation of the visitors, we can manually override some of its (well-chosen) functions to use ensure_sufficient_stack, right?

@Nadrieril
Copy link
Member Author

Oh indeed, you're right! Let's merge then

@Nadrieril Nadrieril merged commit 1c29c19 into AeneasVerif:main Jun 18, 2024
6 checks passed
@Nadrieril Nadrieril deleted the visitors branch June 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework visitors
2 participants