should delete cache instead of write empty hash

Aeon · Nov 9, 2010 · c4c9a1d · c4c9a1d
1 parent a3e1519
commit c4c9a1d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/models/calculator/active_shipping.rb b/app/models/calculator/active_shipping.rb
@@ -56,9 +56,8 @@ def retrieve_rates(origin, destination, packages)
         message = re.message
       end
 
-      Rails.cache.write @cache_key, {} #write empty hash to cache to prevent constant re-lookups
-
-      raise Spree::ShippingError.new("#{I18n.t('shipping_error')}: #{message}")
+      Rails.cache.delete @cache_key # delete cache to prevent constant re-lookups
+      raise Spree::ShippingError, "#{I18n.t('shipping_error')}: #{message}"
     end
   end