Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

fix some data type mismatch issues #26

Merged
merged 2 commits into from
Jul 21, 2016
Merged

Conversation

pxue
Copy link
Contributor

@pxue pxue commented Jul 21, 2016

Problem:

Protoc throws:

2016/07/20 20:19:25 proto: bad wiretype for field data.PokemonData.EggIncubatorId: got wiretype 2, want 0

on some of the fields I'm parsing, looking at the data, it seems right. EggIncubatorId should be type 2 instead of 0, as the value is EggIncubatorProto-1436157207778321898

someone else also mentioned a similar issue here: #25

Fix:

  • modify data types to match the wiretype
  • modify the Unknown6 to distinguish between request and response, they wire different values

@AeonLucid
Copy link
Owner

@pxue
Copy link
Contributor Author

pxue commented Jul 21, 2016

works. changed to string, also changed fixed types to doubles/floats. seems to be returning right values

@AeonLucid AeonLucid merged commit da07663 into AeonLucid:master Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants