Fix shortest path calculation with blocking centroids #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrocamargo
approved these changes
May 25, 2021
|
I have some tests for this but not sure on where to put them. Let me try something and if you don't like it we can discuss |
That would be great if you could include it |
|
I have added my tests for this. |
janzill
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortest path calculation with blocking centroids fails. This is because of blocking_centroid_flows() method in basic_path_finding.pyx
centroids variable contains the number of centroids in the graph. This method as is blocks and unblocks one too many node, which means if the graph is set to block the centroids, the first non centroid node of the graph is always blocked. If a shortest path would contain this node, then we either get no path or wrong path as a result.