Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedro/documentation #267

Merged
merged 23 commits into from
Oct 19, 2021
Merged

Pedro/documentation #267

merged 23 commits into from
Oct 19, 2021

Conversation

pedrocamargo
Copy link
Contributor

No description provided.

@pedrocamargo pedrocamargo added the WIP Work in Progress label Aug 25, 2021
@pedrocamargo
Copy link
Contributor Author

@janzill , the test for path saving is failing. Can you take a look at that since you have written that entire code?

@janzill
Copy link
Contributor

janzill commented Aug 25, 2021

@janzill , the test for path saving is failing. Can you take a look at that since you have written that entire code?

huh, it's passing locally, let me see if I forgot to update the reference files

@janzill
Copy link
Contributor

janzill commented Oct 19, 2021

for reference, @pedrocamargo fixed this in #271 because I dropped the ball on this

@janzill
Copy link
Contributor

janzill commented Oct 19, 2021

Is this still WIP? looks good to me otherwise

@pedrocamargo pedrocamargo removed the WIP Work in Progress label Oct 19, 2021
@pedrocamargo
Copy link
Contributor Author

Is this still WIP? looks good to me otherwise

Nope!!

@pedrocamargo pedrocamargo merged commit 7275c47 into master Oct 19, 2021
@pedrocamargo pedrocamargo deleted the pedro/documentation branch October 19, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants