Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALM sentence #71

Merged
merged 15 commits into from
Jan 24, 2023
Merged

Add ALM sentence #71

merged 15 commits into from
Jan 24, 2023

Conversation

clemarescx
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 79.84% // Head: 80.22% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (e57d962) compared to base (cec1d00).
Patch coverage: 88.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   79.84%   80.22%   +0.37%     
==========================================
  Files          24       25       +1     
  Lines         933      976      +43     
==========================================
+ Hits          745      783      +38     
- Misses        188      193       +5     
Impacted Files Coverage Δ
src/parser.rs 78.43% <0.00%> (-0.31%) ⬇️
src/sentences/mod.rs 0.00% <ø> (ø)
src/sentences/alm.rs 89.74% <89.74%> (ø)
src/parse.rs 81.81% <100.00%> (+0.33%) ⬆️
src/sentences/utils.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/sentences/alm.rs Outdated Show resolved Hide resolved
src/sentences/alm.rs Outdated Show resolved Hide resolved
src/sentences/alm.rs Show resolved Hide resolved
src/sentences/alm.rs Outdated Show resolved Hide resolved
@clemarescx clemarescx marked this pull request as ready for review January 10, 2023 17:10
use arrayvec::ArrayString;
use chrono::{NaiveDate, NaiveTime};
use core::str;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was not needed.
Also it would be nice to keep core/std/alloc separate from other imports.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that's probably rustfmt doing its thing 😅.
Regarding the use of core/std/alloc, I'll move the number_in_range parser to utils to avoid spreading the import of core

@elpiel
Copy link
Member

elpiel commented Jan 24, 2023

Thank once again for this PR!
I will leave 1 task in the main issue for adding an assertion for the 10bit week number as it's not covered by tests.
You're welcome to open a new PR for it if you want to add it.

@elpiel elpiel linked an issue Jan 24, 2023 that may be closed by this pull request
@elpiel elpiel merged commit e0cf006 into AeroRust:main Jan 24, 2023
@clemarescx clemarescx deleted the add_alm_sentence branch January 24, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting additional sentences
2 participants