Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HDT sentence parser #82

Merged
merged 7 commits into from
Mar 11, 2023
Merged

Add HDT sentence parser #82

merged 7 commits into from
Mar 11, 2023

Conversation

ekuinox
Copy link

@ekuinox ekuinox commented Mar 8, 2023

#54 Implements parser for HDT sentence 😄

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.04 🎉

Comparison is base (a95be8c) 79.20% compared to head (e0dfab2) 79.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   79.20%   79.24%   +0.04%     
==========================================
  Files          26       27       +1     
  Lines        1000     1012      +12     
==========================================
+ Hits          792      802      +10     
- Misses        208      210       +2     
Impacted Files Coverage Δ
src/lib.rs 0.00% <ø> (ø)
src/parser.rs 77.82% <0.00%> (-0.31%) ⬇️
src/sentences/mod.rs 0.00% <ø> (ø)
src/sentences/hdt.rs 80.00% <80.00%> (ø)
src/parse.rs 71.42% <100.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elpiel
Copy link
Member

elpiel commented Mar 11, 2023

Thank you very much for your PR 🎉 !

I've just update criterion and set the new MSRV, so if you update with main and fix rustfmt you should be good to go!

ab80227

@ekuinox
Copy link
Author

ekuinox commented Mar 11, 2023

Thank you very much for your PR 🎉 !

I've just update criterion and set the new MSRV, so if you update with main and fix rustfmt you should be good to go!

ab80227

Thank you for reviewing. I merged main branch and fixed format!

@elpiel elpiel merged commit 725394f into AeroRust:main Mar 11, 2023
@ekuinox ekuinox deleted the feature/hdt-parser branch March 11, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants