Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBK sentence #85

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

JasminFragnaud
Copy link

@JasminFragnaud JasminFragnaud commented Mar 17, 2023

#54

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.14 🎉

Comparison is base (fcbe1b0) 80.24% compared to head (405170c) 80.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   80.24%   80.39%   +0.14%     
==========================================
  Files          28       29       +1     
  Lines        1058     1076      +18     
==========================================
+ Hits          849      865      +16     
- Misses        209      211       +2     
Impacted Files Coverage Δ
src/parse.rs 71.25% <0.00%> (-0.91%) ⬇️
src/parser.rs 77.60% <0.00%> (-0.31%) ⬇️
src/sentences/mod.rs 0.00% <ø> (ø)
src/sentences/dbk.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment only for formatting.
It would be nice to improve the tests and probably the parsing too.
I can see value in skipping invalid values but if you manage to pass one of the values to still return that data and None for the rest.

src/sentences/dbk.rs Outdated Show resolved Hide resolved
@elpiel elpiel merged commit 750e0a9 into AeroRust:main Apr 6, 2023
@JasminFragnaud JasminFragnaud deleted the dbk-sentence-parsing branch April 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants