Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction Mode #133

Merged
merged 14 commits into from
Aug 16, 2022
Merged

Interaction Mode #133

merged 14 commits into from
Aug 16, 2022

Conversation

TheChosenEvilOne
Copy link
Contributor

@TheChosenEvilOne TheChosenEvilOne commented Aug 2, 2022

About The Pull Request

Re-adds intents alongside combat mode. I am opening this as a draft because this is (as of writing) a 348 file PR and I haven't finished converting all interactions to the new system.

Why It's Good For The Game

I like intents.

Changelog

🆑
add: A changed version of intents have been re-added as a user preference.
/:cl:

@JinGiant
Copy link
Contributor

JinGiant commented Aug 2, 2022

Would intents and combat mode have to be maintained separately

@TheChosenEvilOne
Copy link
Contributor Author

TheChosenEvilOne commented Aug 2, 2022

Would intents and combat mode have to be maintained separately

no, in fact you could add even more "interaction modes" very easily

@Kapu1178
Copy link

Kapu1178 commented Aug 3, 2022

finish this so i can steal it thanks 👍

@TheChosenEvilOne
Copy link
Contributor Author

I have decided to axe four intent mode in favour of three intent mode for technical reasons.

@dwasint
Copy link

dwasint commented Aug 6, 2022

How does this work with right clicks? did you just remap right click with intents to something else or?

@stanalbatross
Copy link
Contributor

stanalbatross commented Aug 6, 2022

image
image
sprites aren't the same when on/off, literally unplayable

@TheChosenEvilOne
Copy link
Contributor Author

image image sprites aren't the same when on/off, literally unplayable

I made a mistake when copy pasting, it is funny though.

@NiftyRyanyan
Copy link

NiftyRyanyan commented Aug 7, 2022

I really don't see the appeal for this if right clicking still is disarm, That was the main problem with CM. This is really just CM but with a extra grab button at it's current state. But it still is better not having "intents".

@rdragan
Copy link
Collaborator

rdragan commented Aug 11, 2022

Cyborgs need to be fixed before we can merge this.

@TheChosenEvilOne
Copy link
Contributor Author

Cyborgs need to be fixed before we can merge this.

done

@SweptWasTaken
Copy link
Collaborator

"Refined" GitHub crashed when I tried to review it but my brief gaze upon it as well as checking it out in-game with no noticeable bugs fills me with determination.

Really great job TCEO, well done!

Copy link
Collaborator

@Djiq Djiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +32 to +33
if (UI)
UI?.hud.static_inventory -= UI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if U exists then ?. is just slower .

@rdragan rdragan removed the DNM DO. NOT. MERGE. label Aug 16, 2022
@rdragan rdragan merged commit 6494a4a into AetherStation:master Aug 16, 2022
@TheChosenEvilOne TheChosenEvilOne deleted the intent-mode branch August 29, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New thing is getting added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants